Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove duplicate snap installation prompt in get-starknet if it has installed #407

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: remove duplicate snap installation prompt in get-starknet if it has installed #407

wants to merge 3 commits into from

Conversation

stanleyyconsensys
Copy link
Collaborator

@stanleyyconsensys stanleyyconsensys commented Oct 28, 2024 •
edited
Loading

This PR is to remove duplicate snap installation prompt in get-starknet if it has installed by:

  1. Check if it has install by using RPC method ping
  2. If it does n ot throw error, it means the snap has installed, then we dont need to continue
  3. else ask end user install

BEGIN_COMMIT_OVERRIDE
fix: Remove duplicate snap installation prompt in get-starknet if it has installed (#407)
END_COMMIT_OVERRIDE

@stanleyyconsensys stanleyyconsensys requested a review from a team as a code owner October 28, 2024 02:51
@stanleyyconsensys stanleyyconsensys requested review from Akaryatrh and wantedsystem and removed request for a team October 28, 2024 02:51
@khanti42 khanti42 closed this Oct 29, 2024
@stanleyyconsensys stanleyyconsensys added this to the 2.12.0 milestone Nov 5, 2024
@khanti42 khanti42 enabled auto-merge November 5, 2024 14:05
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 5, 2024

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-starknet-snap'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 5, 2024

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-wallet-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akaryatrh Akaryatrh Awaiting requested review from Akaryatrh Akaryatrh is a code owner automatically assigned from Consensys/snaps-factory-reviewers

@wantedsystem wantedsystem Awaiting requested review from wantedsystem wantedsystem is a code owner automatically assigned from Consensys/snaps-factory-reviewers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@stanleyyconsensys @khanti42